Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMORO-3066] Optimizing the efficiency for optimizing-processes rest api #3257

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[AMORO-3066] Optimizing the efficiency for optimizing-processes rest api #3257

wants to merge 6 commits into from

Conversation

klion26
Copy link
Member

@klion26 klion26 commented Oct 15, 2024 •
edited
Loading

Why are the changes needed?

Close #3066.

Brief change log

  • remove the ServerCatalog#tableExists(db, table) in TableController#getOptimizingProcesses because we can reuse the table load logic in the following logic
  • push the offset and limit in mapper#selectOptimizingProcesses(MixedAndIcebergTableDescriptor#getOptimizingProcessesInfo) to db (this can limit the items retrieved from db)

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request
    WeChatWorkScreenshot_b2bc81ed-0dc4-41cc-92bb-f3fd48abde4f
    WeChatWorkScreenshot_5f2c49bd-20a8-4d4e-9218-eba80d441ddd

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@klion26
Copy link
Member Author

klion26 commented Oct 16, 2024

@zhoujinsong @majin1102 could you please have a look when you're free thanks.

zhoujinsong
zhoujinsong reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!
I left some comments, PTAL.

amoro-ams/src/main/java/org/apache/amoro/server/persistence/SqlSessionFactoryProvider.java Outdated Show resolved Hide resolved
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/MixedAndIcebergTableDescriptor.java Show resolved Hide resolved
majin1102
majin1102 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@majin1102 majin1102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for this contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majin1102 majin1102 majin1102 approved these changes

@zhoujinsong zhoujinsong Awaiting requested review from zhoujinsong

Assignees
No one assigned
Labels
module:ams-server Ams server module type:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement]: Improve the efficiency for RESTAPI of optimizing-processes
3 participants
@klion26 @majin1102 @zhoujinsong