[AMORO-3258] Use SimpleFuture to refactor TaskRuntime and eliminate t… #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baiyangtx
reviewed
Oct 16, 2024
| lock.lock(); | ||
| try { | ||
| return taskQueue.poll(); | ||
| return status != Status.CLOSED || status != Status.FAILED ? taskQueue.poll() : null; |
There was a problem hiding this comment.
status != Status.CLOSED && status != Status.FAILED
?
majin1102
force-pushed
the
process-dev
branch
from
b9e04f3
to
ad9ea59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ask lock
Why are the changes needed?
Close #3258 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation