Skip to content

Commit

Permalink
IVY-804 "cache" resolver as a typedef hasn't been functional, remove …
Browse files Browse the repository at this point in the history 
…the duplicate property in the typedef.properties
  • Loading branch information
@jaikiran
jaikiran committed Aug 5, 2017
1 parent df59308 commit 9b21658
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/java/org/apache/ivy/core/settings/typedef.properties
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ sftp = org.apache.ivy.plugins.resolver.SFTPResolver
vsftp = org.apache.ivy.plugins.resolver.VsftpResolver
vfs = org.apache.ivy.plugins.resolver.VfsResolver
jar = org.apache.ivy.plugins.resolver.JarResolver
cache = org.apache.ivy.plugins.resolver.CacheResolver
packager = org.apache.ivy.plugins.resolver.packager.PackagerResolver
obr = org.apache.ivy.osgi.obr.OBRResolver
mirroredurl = org.apache.ivy.plugins.resolver.MirroredURLResolver
Expand Down

1 comment on commit 9b21658

@twogee
Copy link
Contributor

@twogee twogee commented on 9b21658 Aug 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What else must be done to remove it? Deprecate the class?

Here's the relevant discussion which refers to a JIRA issue attempting to document it. In particular, Xavier Hanin stated

CacheResolver has been introduced quite a long time ago and never
documented because it wasn't supposed to be public. I'm still not sure
it's a good idea to use it... IMO, Ivy caching mechanism should be
strong enough to avoid the requirement for a cache resolver, at least
at resolve time. With the addition of dynamic revisions caching in
beta 2, now Ivy cache has all information necessary to be able to
perform a resolve from the cache, without actually requiring to use
the cache resolver. This may require some improvement, like accepting
to use dynamic revision resolution cached data even when they have
exceeded their TTL. This could be a special resolve mode or refresh
mode. With this improvement, the last thing for which the cache
resolver would still be useful is publishing. But even in this case,
I'd prefer using a local repository with useOrigin="true": the
behavior is sligthly different, but I think this should address all
the needs covered by cache resolver which only has its root in bad
caching support and is a design flaw.

Please sign in to comment.