fix(go/adbc/sqldriver): Fix nil pointer panics for query parameters #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
williamleven
changed the title
williamleven
changed the title
zeroshade
approved these changes
Dec 5, 2023
|
@williamleven Looks like your test isn't working currently Your output isn't matching what you're expecting |
williamleven
force-pushed
the
williamleven/fix-gosqldriver-args
branch
from
c57deb3 to
bc85401
Compare
Thanks for having a look so quickly. Yes, apparently had som debug printing left, should have been fixed now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought I would contribute some fixes I've been using locally for the issues described in #1341
I have no previous experience with this repository or with the Arrow memory model so I would say it's likely I've gotten something wrong. Feel free to ask me to improve on my contributions or merely take them as inspiration for some other fix.
Resolves #1341