Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(c): fix typo in static build causing error #2505

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

m-kuhn
Copy link
Contributor

@m-kuhn m-kuhn commented Feb 9, 2025

CMake Warning (dev) at cmake_modules/AdbcDefines.cmake:21 (enable_language):
  project() should be called prior to this enable_language() call.
Call Stack (most recent call first):
  CMakeLists.txt:21 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- {fmt} version: 10.2.2
-- Build type: Release
CMake Error at cmake_modules/BuildUtils.cmake:313 (set_property):
  set_property could not find TARGET adbc_driver_manager_shared.  Perhaps it
  has not yet been created.
Call Stack (most recent call first):
  driver_manager/CMakeLists.txt:18 (add_arrow_lib)


CMake Error at cmake_modules/BuildUtils.cmake:313 (set_property):
  set_property could not find TARGET adbc_driver_postgresql_shared.  Perhaps
  it has not yet been created.
Call Stack (most recent call first):
  driver/postgresql/CMakeLists.txt:29 (add_arrow_lib)


CMake Error at cmake_modules/BuildUtils.cmake:313 (set_property):
  set_property could not find TARGET adbc_driver_sqlite_shared.  Perhaps it
  has not yet been created.
Call Stack (most recent call first):
  driver/sqlite/CMakeLists.txt:39 (add_arrow_lib)

@m-kuhn m-kuhn requested a review from lidavidm as a code owner February 9, 2025 17:02
@github-actions github-actions bot added this to the ADBC Libraries 17 milestone Feb 9, 2025
@m-kuhn m-kuhn changed the title Fix static build fix: static build Feb 9, 2025
@lidavidm lidavidm changed the title fix: static build build(c): fix typo in static build causing error Feb 10, 2025
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lidavidm lidavidm merged commit 09f114f into apache:main Feb 10, 2025
67 of 70 checks passed
@m-kuhn m-kuhn deleted the patch-1 branch February 10, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants