GH-317: [Java] add recipe for vector schema root appender cases #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
reviewed
Aug 21, 2023
java/source/data.rst
Outdated
| import org.apache.arrow.vector.ipc.ArrowReader; | ||
| import org.apache.arrow.vector.util.VectorSchemaRootAppender; | ||
|
|
||
| VectorSchemaRoot appendVectorSchemaRootAsOne(BufferAllocator allocator) { |
There was a problem hiding this comment.
I think it would be clearer if we just constructed the vectors in-memory instead of having to pull in dataset for this
14 tasks
lidavidm
requested changes
Aug 29, 2023
java/source/data.rst
Outdated
| Parquet file with three row groups, gets the three vectors separately, and then | ||
| appends the three vectors together: | ||
|
|
||
| There will be another cases of integration w |
java/source/data.rst
Outdated
Comment on lines
29
to
32
| In some cases, VectorSchemaRoot needs to be modeled as a container. To accomplish | ||
| this, you can use ``VectorSchemaRootAppender.append``. The following code reads a | ||
| Parquet file with three row groups, gets the three vectors separately, and then | ||
| appends the three vectors together: |
java/source/data.rst
Outdated
Comment on lines
48
to
67
| try ( | ||
| IntVector appenderOne = new IntVector("column", | ||
| allocator); | ||
| IntVector appenderTwo = new IntVector("column", | ||
| allocator) | ||
| ) { | ||
| appenderOne.allocateNew(2); | ||
| appenderOne.set(0, 100); | ||
| appenderOne.set(1, 20); | ||
| appenderOne.setValueCount(2); | ||
| appenderTwo.allocateNew(2); | ||
| appenderTwo.set(0, 34); | ||
| appenderTwo.set(1, 75); | ||
| appenderTwo.setValueCount(2); | ||
| try ( | ||
| final VectorSchemaRoot rootOne = new VectorSchemaRoot( | ||
| Collections.singletonList(appenderOne)); | ||
| final VectorSchemaRoot rootTwo = new VectorSchemaRoot( | ||
| Collections.singletonList(appenderTwo)) | ||
| ) { |
There was a problem hiding this comment.
Why so much nesting? This can be written more clearly.
lidavidm
requested changes
Aug 29, 2023
java/source/data.rst
Outdated
| final VectorSchemaRoot rootTwo = new VectorSchemaRoot( | ||
| Collections.singletonList(appenderTwo)) | ||
| ) { | ||
| if (result == null) { |
java/source/data.rst
Outdated
| VectorSchemaRootAppender.append(result, rootOne, rootTwo); | ||
| System.out.print(result.contentToTSVString()); | ||
| } | ||
| result.close(); |
java/source/data.rst
Outdated
| appenderTwo.set(1, 75); | ||
| appenderTwo.setValueCount(2); | ||
| try ( | ||
| final VectorSchemaRoot rootOne = new VectorSchemaRoot( |
There was a problem hiding this comment.
you can just use a schema and VectorSchemaRoot.create to get rid of the nesting here by initializing everything in the top-level try-with-resources
lidavidm
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve #317