GH-324: [Java] c data interface to share value vector, vsr and reader #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vibhatha
reviewed
Sep 5, 2023
java/source/cdata.rst
Outdated
|
|
||
| For Python Consumer and Java Producer, please consider: | ||
|
|
||
| - The Root Allocator should be shared for all memory allocations. |
There was a problem hiding this comment.
should this be RootAllocator?
There was a problem hiding this comment.
Thanks, let me update that
There was a problem hiding this comment.
@davisusanibar if it is the case, there are a few instances below.
vibhatha
reviewed
Sep 5, 2023
vibhatha
reviewed
Sep 5, 2023
java/source/cdata.rst
Outdated
| Sharing ValueVector | ||
| ******************* | ||
|
|
||
| Java Side: |
vibhatha
reviewed
Sep 5, 2023
java/source/cdata.rst
Outdated
|
|
||
| [1, 7, 93] | ||
|
|
||
| Python Side: |
vibhatha
reviewed
Sep 5, 2023
java/source/cdata.rst
Outdated
|
|
||
| jvmargs=["-Darrow.memory.debug.allocator=true"] | ||
| jpype.startJVM(*jvmargs, jvmpath=jpype.getDefaultJVMPath(), classpath=[ | ||
| "./target/java-python-by-cdata-1.0-SNAPSHOT-jar-with-dependencies.jar"]) |
There was a problem hiding this comment.
It would be nice to leave a comment regarding the jar we have mentioned here.
Co-authored-by: Vibhatha Lakmal Abeykoon <[email protected]>
…ook into c-data-recipes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #324