Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-26648: [C++] Optimize union equality comparison #45384

Merged
merged 6 commits into from
Feb 4, 2025
Merged
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 37 additions & 11 deletions cpp/src/arrow/compare.cc
Original file line number Diff line number Diff line change
Expand Up @@ -381,23 +381,49 @@ class RangeDataEqualsImpl {
const int8_t* right_codes = right_.GetValues<int8_t>(1);

// Unions don't have a null bitmap
int64_t run_start = 0; // Start index of the current run

for (int64_t i = 0; i < range_length_; ++i) {
const auto type_id = left_codes[left_start_idx_ + i];
if (type_id != right_codes[right_start_idx_ + i]) {
const auto current_type_id = left_codes[left_start_idx_ + i];

if (current_type_id != right_codes[right_start_idx_ + i]) {
result_ = false;
break;
}
const auto child_num = child_ids[type_id];
// XXX can we instead detect runs of same-child union values?
RangeDataEqualsImpl impl(
options_, floating_approximate_, *left_.child_data[child_num],
*right_.child_data[child_num], left_start_idx_ + left_.offset + i,
right_start_idx_ + right_.offset + i, 1);
if (!impl.Compare()) {
result_ = false;
break;
// Check if the current element breaks the run
if (i > 0 && current_type_id != left_codes[left_start_idx_ + i - 1]) {
// Compare the previous run
const auto previous_child_num = child_ids[left_codes[left_start_idx_ + i - 1]];
int64_t run_length = i - run_start;

RangeDataEqualsImpl impl(
options_, floating_approximate_, *left_.child_data[previous_child_num],
*right_.child_data[previous_child_num],
left_start_idx_ + left_.offset + run_start,
right_start_idx_ + right_.offset + run_start, run_length);

if (!impl.Compare()) {
result_ = false;
return Status::OK();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can break just as above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the feedback! just implemented the suggestions

}

// Start a new run
run_start = i;
}
}

// Handle the final run
const auto final_child_num = child_ids[left_codes[left_start_idx_ + run_start]];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably only do this final comparison if result_ is still true.

int64_t final_run_length = range_length_ - run_start;

RangeDataEqualsImpl impl(
options_, floating_approximate_, *left_.child_data[final_child_num],
*right_.child_data[final_child_num], left_start_idx_ + left_.offset + run_start,
right_start_idx_ + right_.offset + run_start, final_run_length);

if (!impl.Compare()) {
result_ = false;
}
return Status::OK();
}

Expand Down
Loading