GH-45485: [Dev] Simplify pull request template #45599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Documentation
awaiting committer review
raulcd
approved these changes
Feb 21, 2025
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 12cdaaa. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
kou
added a commit
to kou/arrow
that referenced
this pull request
Feb 25, 2025
### Rationale for this change It seems that the current comment based pull request template isn't read carefully. ### What changes are included in this PR? * Remove explanations as comments * Keep a basic introduction in the top as a normal text not a comment * Use normal texts not comments for breaking changes and critical fix ### Are these changes tested? No. ### Are there any user-facing changes? No. This is only for developers. * GitHub Issue: apache#45485 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
arashandishgar
pushed a commit
to arashandishgar/arrow
that referenced
this pull request
Feb 25, 2025
### Rationale for this change It seems that the current comment based pull request template isn't read carefully. ### What changes are included in this PR? * Remove explanations as comments * Keep a basic introduction in the top as a normal text not a comment * Use normal texts not comments for breaking changes and critical fix ### Are these changes tested? No. ### Are there any user-facing changes? No. This is only for developers. * GitHub Issue: apache#45485 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It seems that the current comment based pull request template isn't read carefully.
What changes are included in this PR?
Are these changes tested?
No.
Are there any user-facing changes?
No. This is only for developers.