Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [R] Bump the timeout for library download #45607

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

jonkeane
Copy link
Member

Rationale for this change

Increase the timeout, see if that's the issue on CRAN.

What changes are included in this PR?

Timeout, increased

Are these changes tested?

No

Are there any user-facing changes?

Slightly slower downloads are possible.

@jonkeane jonkeane requested a review from assignUser as a code owner February 23, 2025 23:09
@jonkeane jonkeane changed the title MINOR: Bump the timeout for R library download MINOR: [R] Bump the timeout for library download Feb 23, 2025
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Feb 23, 2025
@jonkeane jonkeane requested a review from amoeba February 24, 2025 00:19
Copy link
Member

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jonkeane jonkeane merged commit d59a736 into apache:main Feb 24, 2025
12 checks passed
@jonkeane jonkeane deleted the timeout_update branch February 24, 2025 15:45
amoeba pushed a commit that referenced this pull request Feb 24, 2025
### Rationale for this change

Increase the timeout, see if that's the issue on CRAN.

### What changes are included in this PR?

Timeout, increased

### Are these changes tested?

No

### Are there any user-facing changes?

Slightly slower downloads are possible.
@amoeba
Copy link
Member

amoeba commented Feb 24, 2025

Cherry-picked onto maint-19.0.1-r as 38973615a48e4cbd1251718bab55e6e4af9f4f0c.

Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d59a736.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

kou pushed a commit to kou/arrow that referenced this pull request Feb 25, 2025
### Rationale for this change

Increase the timeout, see if that's the issue on CRAN.

### What changes are included in this PR?

Timeout, increased

### Are these changes tested?

No

### Are there any user-facing changes?

Slightly slower downloads are possible.
arashandishgar pushed a commit to arashandishgar/arrow that referenced this pull request Feb 25, 2025
### Rationale for this change

Increase the timeout, see if that's the issue on CRAN.

### What changes are included in this PR?

Timeout, increased

### Are these changes tested?

No

### Are there any user-facing changes?

Slightly slower downloads are possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants