AVRO-4013: [PHP] PHP 8 deprecations (#3000)

apache · Jul 7, 2024 · 701a844 · 701a844
1 parent f6f3972
commit 701a844
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/lang/php/lib/DataFile/AvroDataIOWriter.php b/lang/php/lib/DataFile/AvroDataIOWriter.php
@@ -66,6 +66,10 @@ class AvroDataIOWriter
      * @var string compression codec
      */
     private $codec;
+    /**
+     * @var string sync marker
+     */
+    private $sync_marker;
 
     /**
      * @param AvroIO $io

diff --git a/lang/php/lib/Protocol/AvroProtocol.php b/lang/php/lib/Protocol/AvroProtocol.php
@@ -29,6 +29,7 @@
  */
 class AvroProtocol
 {
+    public $protocol;
     public $name;
     public $namespace;
     public $schemata;

diff --git a/lang/php/lib/Protocol/AvroProtocolMessage.php b/lang/php/lib/Protocol/AvroProtocolMessage.php
@@ -27,6 +27,8 @@
 
 class AvroProtocolMessage
 {
+    public $name;
+
     /**
      * @var AvroRecordSchema $request
      */

diff --git a/lang/php/test/DataFileTest.php b/lang/php/test/DataFileTest.php
@@ -20,6 +20,7 @@
 namespace Apache\Avro\Tests;
 
 use Apache\Avro\DataFile\AvroDataIO;
+use DateTime;
 use PHPUnit\Framework\TestCase;
 
 class DataFileTest extends TestCase
@@ -61,7 +62,7 @@ protected function add_data_file($data_file)
 
     public static function current_timestamp()
     {
-        return strftime("%Y%m%dT%H%M%S");
+        return date_format(new DateTime, 'Y-m-d H:i:s');
     }
 
     public function test_write_read_null_round_trip()