AVRO-2108: [Java] DoubleArray converts double to float (#3285)

* fixing DoubleArray float cast * add new line * preventing boxing --------- Co-authored-by: Martin Grigorov <[email protected]>
apache · Jan 21, 2025 · fe0261d · fe0261d
1 parent d843fc5
commit fe0261d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/lang/java/avro/src/main/java/org/apache/avro/generic/PrimitivesArrays.java b/lang/java/avro/src/main/java/org/apache/avro/generic/PrimitivesArrays.java
@@ -58,7 +58,7 @@ public Integer get(int i) {
 
     /**
      * Direct primitive int access.
-     * 
+     *
      * @param i : index.
      * @return value at index.
      */
@@ -162,7 +162,7 @@ public Long get(int i) {
 
     /**
      * Direct primitive int access.
-     * 
+     *
      * @param i : index.
      * @return value at index.
      */
@@ -273,7 +273,7 @@ public Boolean get(int i) {
 
     /**
      * Direct primitive int access.
-     * 
+     *
      * @param i : index.
      * @return value at index.
      */
@@ -431,7 +431,7 @@ public Float get(int i) {
 
     /**
      * Direct primitive int access.
-     * 
+     *
      * @param i : index.
      * @return value at index.
      */
@@ -535,7 +535,7 @@ public Double get(int i) {
 
     /**
      * Direct primitive int access.
-     * 
+     *
      * @param i : index.
      * @return value at index.
      */
@@ -550,7 +550,7 @@ public void add(int location, Double o) {
       if (o == null) {
         return;
       }
-      this.add(location, o.floatValue());
+      this.add(location, o.doubleValue());
     }
 
     public void add(int location, double o) {

diff --git a/lang/java/avro/src/test/java/org/apache/avro/generic/PrimitivesArraysTest.java b/lang/java/avro/src/test/java/org/apache/avro/generic/PrimitivesArraysTest.java
@@ -277,4 +277,18 @@ void doubleArray() {
       Assertions.assertEquals((101 - i) * 3.0d, doubleArray.get(i - 1));
     }
   }
+
+  @Test
+  void testDoubleArrayPreservesPrecisionForNonFloatRepresentableValues() {
+    final PrimitivesArrays.DoubleArray doubleArray = new PrimitivesArrays.DoubleArray(1,
+        Schema.createArray(Schema.create(Schema.Type.DOUBLE)));
+
+    // This value cannot be represented as a float
+    Double nonFloatDouble = .9;
+    Assertions.assertNotEquals(.9, nonFloatDouble.floatValue());
+
+    // Assert that the double array does not lose precision when adding
+    doubleArray.add(nonFloatDouble);
+    Assertions.assertEquals(nonFloatDouble, doubleArray.get(0));
+  }
 }