-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVRO-3803: Python patched up ipc issues #2319
Open
asosnovsky
wants to merge
8
commits into
apache:main
Choose a base branch
from
asosnovsky:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kojiromike
reviewed
Jul 15, 2023
kojiromike
reviewed
Jul 15, 2023
kojiromike
reviewed
Jul 15, 2023
Co-authored-by: Michael A. Smith <[email protected]>
Co-authored-by: Michael A. Smith <[email protected]>
kojiromike
reviewed
Jul 18, 2023
I think this is good, but can we attach it to any existing tickets? If not, I can open a new one. |
@kojiromike no I don't have a JIRA for this. Please open one :) thank you! |
kojiromike
changed the title
AVRO-0: Python patched up ipc issues
AVRO-3803: Python patched up ipc issues
Jul 19, 2023
@asosnovsky could I trouble you to check if this implementation resolves AVRO-1639? |
As far as resolving the conflicts: If you take your branch as-is and run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVRO-3803
What is the purpose of the change
except
was pointing atschema.AvroException
instead ofavro.errors.AvroException
Verifying this change
This change added tests and can be verified as follows:
Documentation