AVRO-2921: Add Type Hints to avro.schema #2350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
kojiromike
force-pushed
the
avro-2921-schema
branch
7 times, most recently
from
9f499ce
to
df05ad8
Compare
|
@RyanSkraba if you're not the right person to review this, can you suggest someone else? (I don't even think it necessarily needs to be someone with the commit bit.) |
kojiromike
force-pushed
the
avro-2921-schema
branch
from
f21dde4
to
83de021
Compare
RyanSkraba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This is part of the incremental effort to add type checking to the Python implementation.
Verifying this change
This change is already covered by existing tests.
Documentation
This change does not add any new user-facing features. Type annotations may add clearer responses for users who elect to run a type checker. Hopefully those responses are sufficient documentation in themselves.