AVRO-3906: Add .NET 8.0 support #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcsizmadia
changed the title
|
It seems like there is an issue with the C# ARM64 build if the XZ library package Joveler.Compression.XZ is bumped to the latest. The latest package works on my dev environment and succeeds with the standard github worklows, except on ARM64. Added comment about it in the |
martin-g
approved these changes
Nov 20, 2023
|
Fyi, I created #2523 back in September asa preparation for the NET 8 analyzer warning about it, however it wont be needed any more, I will reject that PR once this is merged |
|
Merged. @martin-g if you rebase those failing PRs with main it should be ok now. |
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
* Add NEt8.0 support * Add liblzma to ARM 64 C# * Restore XZ library version * Add comment for Joveler.Compression.XZ ARM64 issue --------- Co-authored-by: Zoltan Csizmadia <[email protected]>
|
Nice work! Definitely helps! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add .NET 8.0 support (AVRO-3906)
Verifying this change
This change is already covered by existing tests.
Documentation