AVRO-3914: Add nanos support for the Java SDK #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May need a doc change on time description |
martin-g
changed the title
|
Moving this forward. Thanks for the review @clesaec |
arkanovicz
reviewed
Jan 24, 2024
Comment on lines
+284
to
+289
| private static final LocalTimestampMicros LOCAL_TIMESTAMP_NANOS_TYPE = new LocalTimestampMicros(); | ||
|
|
||
| public static LocalTimestampMicros localTimestampNanos() { | ||
| return LOCAL_TIMESTAMP_NANOS_TYPE; | ||
| } | ||
|
|
There was a problem hiding this comment.
Shoudln't it be LocalTimestampNanos class here?
There was a problem hiding this comment.
Yes, you're correct! Do you want to raise the PR?
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
AVRO-3914
Verifying this change
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation