-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVRO-3978: Build with Java 11 minimum #2855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks for working on this @jbonofre
I think it makes sense to set the minimum to JDK17 as suggested on the devlist: https://lists.apache.org/thread/6vbd3w5qk7mpb5lyrfyf2s0z1cymjt5w
Spark 4 will support JDK17 as a minimum and I see more project going into that direction since JDK11 has lost support September 2023.
Looks like the integration tests are still relying on JDK8:
Looks like:
|
@Fokko yup, updating it :) Thanks ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great first step towards JDK17 :)
@Fokko I will create another PR for JDK11 for avro 1.x branch and update this one for JDK17 |
AFAIR 1.11.x should stay with JDK 8 |
@martin-g yes for 1.11 but what about 1.12 ? We keep JDK8 for 1.12 as well ? |
My gist from the mail list:
I'll go ahead and merge this since there is consensus on the ML |
👍 Thanks @Fokko ! |
What is the purpose of the change
Upgrade Avro
main
to build with Java 11 minimum (and remove reference to Java 8).Verifying this change
I verified the whole build worked on my machine.
Documentation
Avro wiki should be updated to mention Avro 1.12.x will be Java 11 minimum, and Avro 1.11.x is still Java 8 compliant.