AVRO-4069: Remove Reader String Cache from Generic Datum Reader #3194
Conversation
|
@martin-g Thanks so much for your support on these PRs. Here's another one that needs attention that has a positive performance impact. |
There was a problem hiding this comment.
Have you looked at the Git commit / JIRA that introduced this cache ?
I guess it has been added for a reason.
Now you remove one of the tests without good reason (at least I don't see it) and without adding better tests.
https://issues.apache.org/jira/browse/AVRO-3531 talks about a real world scenario where the code without the cache caused issues.
| @@ -33,27 +31,9 @@ public class TestGenericDatumReader { | |||
|
|
|||
| private static final Random r = new Random(System.currentTimeMillis()); | |||
|
|
|||
| @Test | |||
| void readerCache() { | |||
There was a problem hiding this comment.
Why do you delete the test ?
Looking at it I think it should still work. You just need to remove the ctor parameter.
|
AVRO-3531 was a thread safety bug. Its fix #1719 changed the types of the caches and moved them into I don't know whether |
What is the purpose of the change
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation