AVRO-4073: Create Convenience toBytes Method for Datum Writer #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belugabehr
force-pushed
the
belugabehr/AVRO-4073
branch
4 times, most recently
from
cf86303
to
ca792ee
Compare
martin-g
approved these changes
Oct 6, 2024
| * depth first, writing each leaf value in the schema from the datum to the byte | ||
| * array. | ||
| */ | ||
| byte[] toByteArray(D datum) throws IOException; |
There was a problem hiding this comment.
The two implementations are the same at the moment. Would it make sense to make this method a method with default implementation?
There was a problem hiding this comment.
Touché. Much Cleaner. Thanks for the suggestion. Updated.
belugabehr
force-pushed
the
belugabehr/AVRO-4073
branch
from
ca792ee
to
205d23d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Verifying this change
This change added tests.