Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-2955: Avro-C: Support all Visual Studio versions from 2010 to 2019 #977

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

kiyolee
Copy link

@kiyolee kiyolee commented Nov 7, 2020

AVRO-2955: Avro-C: Support all Visual Studio versions from 2010 to 2019

Fix compiling using Visual Studio 2010|2013|2015|2017|2019.
Fix building using either cmake/ninja or cmake/visualstudio.
Fix testing using cmake/ninja.
Improve Windows compatibility.
All existing tests passed using all Visual Studio versions mentioned.

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    *** No new functionality added. All existing tests passed.

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does
      *** No new functionality added.

@github-actions github-actions bot added the C label Nov 7, 2020
@kiyolee kiyolee force-pushed the vs-support branch 3 times, most recently from c57e983 to bec97f9 Compare November 17, 2020 10:44
@kiyolee kiyolee force-pushed the vs-support branch 3 times, most recently from 27bb6dd to 088e817 Compare November 24, 2020 12:32
@kiyolee kiyolee force-pushed the vs-support branch 2 times, most recently from b7404ab to 662fa52 Compare December 8, 2020 07:56
@kiyolee kiyolee force-pushed the vs-support branch 3 times, most recently from 9d01a5e to 6171123 Compare January 19, 2021 10:32
@kiyolee kiyolee force-pushed the vs-support branch 2 times, most recently from 500ffc2 to 68041cb Compare February 1, 2021 08:27
@kiyolee kiyolee force-pushed the vs-support branch 2 times, most recently from 97f844c to 0801bac Compare February 8, 2021 12:12
@kiyolee kiyolee force-pushed the vs-support branch 2 times, most recently from d40cf8c to b42ccb0 Compare February 25, 2021 10:50
@kiyolee kiyolee force-pushed the vs-support branch 2 times, most recently from 8b02ea9 to 14a992a Compare March 18, 2021 07:16
@kiyolee kiyolee force-pushed the vs-support branch 2 times, most recently from aacdba7 to 102b68f Compare April 2, 2021 11:10
@kiyolee kiyolee force-pushed the vs-support branch 2 times, most recently from 878bbac to 93dc745 Compare April 25, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants