[CALCITE-6248] Illegal dates are accepted by casts #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zstan this builds on top of your previous fix for a similar issue with timestamps. |
mihaibudiu
force-pushed
the
issue6248
branch
from
045864e to
657e500
Compare
mihaibudiu
force-pushed
the
issue6248
branch
from
657e500 to
4a6f39a
Compare
YiwenWu
reviewed
Mar 19, 2024
| * values for days and months, and accepts spaces around the value. | ||
| * @param s A string representing a date. | ||
| */ | ||
| private static void validateLenientDate(String s) { |
There was a problem hiding this comment.
There is no problem using this method to verify, but this implementation only verifies DAY. Is it possible to use a more general verification method, such as：
DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd");
try {
LocalDate date = LocalDate.parse(dateString, formatter);
return true;
} catch (DateTimeParseException e) {
return false;
}
There was a problem hiding this comment.
This does the exact same validation as the existing function validateDate.
So maybe we should improve that function too.
There was a problem hiding this comment.
I have added a commit to validate month and year values.
Turns out year 0 is not legal in the Gregorian calendar, so I had to delete some tests that were using it.
YiwenWu
approved these changes
Mar 20, 2024
Signed-off-by: Mihai Budiu <[email protected]>
|
If CI passes I will merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.