Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-6697] Update Scott-data-hsqldb from 0.1 to 0.2 in Avatica #265

Closed
wants to merge 1 commit into from
Closed

[CALCITE-6697] Update Scott-data-hsqldb from 0.1 to 0.2 in Avatica #265

wants to merge 1 commit into from

Conversation

caicancai
Copy link
Member

@caicancai caicancai commented Nov 17, 2024 •
edited
Loading

@stoty
Copy link
Contributor

stoty commented Nov 18, 2024

The test failures look related.
Maybe hsqldb.version also needs to be synced ?

@caicancai
Copy link
Member Author

The test failures look related. Maybe hsqldb.version also needs to be synced ?

I'll try it later, thanks for the reminder

@caicancai
Copy link
Member Author

@stoty It looks like some of the data in the test set has been transformed. I’m not sure whether to continue this work. Do you have any suggestions?

@stoty
Copy link
Contributor

stoty commented Nov 25, 2024

Is the hsql update a security issue ?
If not, I'd just leave it alone, it's only used for tests.

Otherwise, all the tests using the dataset and hsql would need to be checked and updated to work with the new HSQL and test data.

@caicancai caicancai closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caicancai @stoty