[CALCITE-6212] Config locale = 'en_US' for javadoc task #3637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snuyanzin
reviewed
Jan 18, 2024
| @@ -486,6 +486,8 @@ allprojects { | |||
| (options as StandardJavadocDocletOptions).apply { | |||
| // Please refrain from using non-ASCII chars below since the options are passed as | |||
| // javadoc.options file which is parsed with "default encoding" | |||
| // locale should be placed at the head of any options: https://docs.gradle.org/current/javadoc/org/gradle/external/javadoc/CoreJavadocOptions.html#getLocale | |||
| locale = "en_US" | |||
There was a problem hiding this comment.
Nice finding
Am I correct that same thing should be done for Avatica?
There was a problem hiding this comment.
Yes, I do think so. I'll do this for avatica once this is merged.
There was a problem hiding this comment.
The PR against avatica is now available for review: apache/calcite-avatica#235
|
Is it better to register the affected version with Jira? |
libenchao
changed the title
I've logged CALCITE-6212, thanks~ |
JiajunBernoulli
approved these changes
Jan 19, 2024
github-actions bot
pushed a commit
to macroguo-ghy/calcite
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.