Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-6817] Add string representation of default nulls direction for RelNode #4184

Merged
merged 1 commit into from
Feb 10, 2025
Merged

[CALCITE-6817] Add string representation of default nulls direction for RelNode #4184

merged 1 commit into from
Feb 10, 2025

Conversation

ILuffZhe
Copy link
Contributor

@ILuffZhe ILuffZhe commented Feb 6, 2025

No description provided.

@ILuffZhe ILuffZhe force-pushed the CALCITE-6817 branch 2 times, most recently from ca4a128 to 8641493 Compare February 7, 2025 11:53
@rubenada
Copy link
Contributor

rubenada commented Feb 7, 2025

LGTM

suibianwanwank
suibianwanwank approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@suibianwanwank suibianwanwank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, RelFieldCollation also exists in Window, would you consider adding it in this PR?

@ILuffZhe
Copy link
Contributor Author

ILuffZhe commented Feb 8, 2025 •
edited
Loading

Overall LGTM, RelFieldCollation also exists in Window, would you consider adding it in this PR?

I assume you mean OVER call, like OVER (PARTITION BY id ORDER BY age DESC nulls last).
This is a RexNode and its string representation is generated by computing digest. Seems current flag cannot be passed into, or do I miss something?

@ILuffZhe ILuffZhe closed this Feb 8, 2025
@ILuffZhe ILuffZhe reopened this Feb 8, 2025
@ILuffZhe ILuffZhe added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Feb 9, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ILuffZhe ILuffZhe merged commit f1c370a into apache:main Feb 10, 2025
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caicancai caicancai caicancai approved these changes

@suibianwanwank suibianwanwank suibianwanwank approved these changes

Assignees
No one assigned
Labels
LGTM-will-merge-soon Overall PR looks OK. Only minor things left.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ILuffZhe @rubenada @caicancai @suibianwanwank