Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6690, #6933 - google-secret-manager extend coverage and native #6935

Merged

Conversation

JiriOndrusek
Copy link
Contributor

fixes #6690
fixes #6933

Google-secret-manager native support is added:

  • tech preview status is changed to stable
  • extension and tests are moved from JVM modules into standard one
  • native support requires duplication of some code (which is already present in google-pubsub). The refactor is not part of this PR (as it would make the whole change more complicated). I created a ticket Google-secret-manager and google-pubsub: create a common extension support #6934 to do such refactor in the future.

Test coverage is added:

  • the real backend is required (as was before)
  • pubsub test resource had to be added to simulate the sending of the message to the secret refresh topic (see more details in the comment of GoogleSecretManagerTest class)

@JiriOndrusek JiriOndrusek force-pushed the google-service-manager-native-support branch from 6a649f6 to d6f928e Compare January 23, 2025 15:12
@jamesnetherton
Copy link
Contributor

Please rebase as main just got bumped to 3.19.0-SNAPSHOT. You'll need to update the 'native since' property to 3.19.0.

The refactor is not part of this PR (as it would make the whole change more complicated)

That's fine, but we should aim to get #6934 done ASAP. We can't have the potential for duplicate substitutions on the classpath.

@JiriOndrusek
Copy link
Contributor Author

I'll rebase right now and will start working on #6934 during today, if needed I can prepare the fix as a second commit to this PR

@JiriOndrusek JiriOndrusek force-pushed the google-service-manager-native-support branch from d6f928e to 65e3267 Compare January 24, 2025 07:27
@JiriOndrusek JiriOndrusek force-pushed the google-service-manager-native-support branch from 65e3267 to 746ffb5 Compare January 24, 2025 07:30
@jamesnetherton jamesnetherton merged commit 3270856 into apache:main Jan 24, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google-secret-manager: native support Google-secret-manager: less important test coverage
4 participants