Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog(Kaoto): Kaoto 2.2 release #1238

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

lordrip
Copy link
Contributor

@lordrip lordrip commented Sep 20, 2024

No description provided.

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content LGTM, but the formatting should be changed to favor the markdown over HTML style. I think that the visualization may suffer by adding some fixed format.

<img src="cover.png" alt="Kaoto" height="400"/>
</div>

<br/><strong>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd avoid to have all that text in strong. Better highlight a few keywords instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the <strong> tag


- New look and feel: The flow elements have been redesigned to provide a more modern and clean look. The new design is more intuitive and user-friendly, making it easier to work with your integrations.

<div style="text-align: center">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd avoid adding too much divs around. I think you can use the format like.

![Canvas](canvas.png)
_Figure 1. Canvas_

I cannot recall if there is the possibility to resize. If not, it would be probably good to publish the image with the required size.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I'll reupload the images

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm, the issue with that is the images will lose quality, so they would look fine in the website but if you want to zoom in to see the details, then it will be "un-pretty"


You can also check out our [examples repository](https://github.com/KaotoIO/kaoto-examples) to see some more advanced use cases which were set up using Kaoto.

<div style="text-align: center">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this div is useless. Keep it using MD format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With all due respect, it's not useless, it centers the image in the webpage 😃

@lordrip
Copy link
Contributor Author

lordrip commented Sep 20, 2024

Hi @squakez, the <div> purpose is to center the image within the page, here you can find the previous blog post that I did.

This is how it looks like in the website: https://camel.apache.org/blog/2024/07/kaoto-release-2.1.0/

@lordrip lordrip marked this pull request as ready for review September 20, 2024 11:08
Copy link

🚀 Preview is available at https://pr-1238--camel.netlify.app

@lordrip lordrip marked this pull request as draft September 20, 2024 12:30
---
<br/><br/>
<div style="text-align: center">
We invite you to explore these new features on your summer integrations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summer integrations? is it a left-over of a copy-paste?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my bad, I rephrased it

@zregvart
Copy link
Member

I'm wondering about the need to center the images, this is something that is already present in the default layout/styling. For example the create-component-1.png image is quite narrow and on the website it is centered, the plain markdown syntax should be enough here.

@zregvart
Copy link
Member

In addition to that, the inline styling is not allowed by the content security policy and will be ignored by the browser.

@squakez
Copy link
Contributor

squakez commented Sep 20, 2024

+1 to @zregvart comments. IMO we should limit the quantity of html and have a common look and feel and easier maintenance in the future. When we change the layout, the HTML that looks pretty now, may no longer look pretty after. Said that, I have no objection if you want to merge it.

@lordrip
Copy link
Contributor Author

lordrip commented Sep 20, 2024

Agreed. I resized the images and removed the <div>s, let's wait for the preview and see what it looks like. Thanks @squakez and @zregvart for the feedback

Copy link

🚀 Preview is available at https://pr-1238--camel.netlify.app

2 similar comments
Copy link

🚀 Preview is available at https://pr-1238--camel.netlify.app

Copy link

🚀 Preview is available at https://pr-1238--camel.netlify.app

@apupier
Copy link
Contributor

apupier commented Sep 20, 2024

"related posts" seems broken:
image

(but not foudn yet another artickle with related blogpost to compare and check if it is related to this PR or not)

@apupier
Copy link
Contributor

apupier commented Sep 20, 2024

for other blogposts, the "related posts" are below the article, there is only this one with them on the side

@lordrip
Copy link
Contributor Author

lordrip commented Sep 20, 2024

"related posts" seems broken:

(but not foudn yet another artickle with related blogpost to compare and check if it is related to this PR or not)

I don't why would that be, as far as I can see, there's a mistake with the table MD definition, not sure if it relates, I fixed it and pushed it again.

Copy link

🚀 Preview is available at https://pr-1238--camel.netlify.app

@apupier
Copy link
Contributor

apupier commented Sep 20, 2024

"related posts" still broken:
image

@lordrip
Copy link
Contributor Author

lordrip commented Sep 20, 2024

"related posts" still broken:

@apupier I don't think that's the updated website yet, is still showing bullet points for each feature, let's wait for another update, it seems there's a bit of delay

@lordrip lordrip marked this pull request as ready for review September 20, 2024 15:01
Copy link

🚀 Preview is available at https://pr-1238--camel.netlify.app

Copy link

🚀 Preview is available at https://pr-1238--camel.netlify.app

@apupier apupier merged commit b954ce9 into apache:main Sep 20, 2024
1 check passed
@lordrip lordrip deleted the blog/kaoto-2.2-release branch September 20, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants