-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAMEL-20266: Use high-level Azure Service Bus client #13862
CAMEL-20266: Use high-level Azure Service Bus client #13862
Conversation
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
...cebus/src/main/java/org/apache/camel/component/azure/servicebus/ServiceBusConfiguration.java
Outdated
Show resolved
Hide resolved
Thanks for working on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really promising and good. Thanks!
The integration tests have been rewritten and/or refactored to use common framework and are now functioning correctly. We still have 2 failures arising from CAMEL-20691; these failures should disappear once #13872 is merged. Whilst I do still intend to continue to improve low-level unit test coverage, since the integration tests require a Service Bus namespace and do not run automatically during CI builds, we have now reached a state where we have scenario/coverage parity with the previously existing tests, therefore I am marking this PR ready to review. |
Okay we have merged some other PRs so this PR needs to be updated thanks |
…e-service-bus-client
Oh do you mind updating the upgrade guide doc about this change so users would be aware that some options are changed etc. Add a section to |
* CAMEL-20266: Use high-level Azure Service Bus client * Add default value to `maxConcurrentCalls` metadata * Commit missing generated sources * Rewrite integration test for ServiceBusConsumer * Rewrite integration test for ServiceBusProducer * Correct typos * Refactor `ServiceBusSenderOperationsTest` and framework * Remove redundant tests and framework * Implement unit test for `ServiceBusConsumer` * Fix formatting * Tweak `ServiceBusConsumerTest` verifications * Improve `ServiceBusConsumerTest` assertions * Document configuration changes in migration guide
Description
Refactor Azure Service Bus consumer to use the high-level
ServiceBusProcessorClient
instead ofServiceBusReceiverAsyncClient
. Amongst other benefits, the high-level client takes care of protocol errors, performs automatic re-connection and can support concurrent message consumption.Target
camel-3.x
, whereas Camel 4 uses themain
branch)Tracking
Apache Camel coding standards and style
I checked that each commit in the pull request has a meaningful subject line and body.
I have run
mvn clean install -DskipTests
locally and I have committed all auto-generated changes