Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-20266: Use high-level Azure Service Bus client #13862

Merged

Conversation

dylanpiergies
Copy link
Contributor

Description

Refactor Azure Service Bus consumer to use the high-level ServiceBusProcessorClient instead of ServiceBusReceiverAsyncClient. Amongst other benefits, the high-level client takes care of protocol errors, performs automatic re-connection and can support concurrent message consumption.

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.

  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@davsclaus
Copy link
Contributor

Thanks for working on this

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really promising and good. Thanks!

@dylanpiergies
Copy link
Contributor Author

The integration tests have been rewritten and/or refactored to use common framework and are now functioning correctly. We still have 2 failures arising from CAMEL-20691; these failures should disappear once #13872 is merged.

Whilst I do still intend to continue to improve low-level unit test coverage, since the integration tests require a Service Bus namespace and do not run automatically during CI builds, we have now reached a state where we have scenario/coverage parity with the previously existing tests, therefore I am marking this PR ready to review.

@dylanpiergies dylanpiergies marked this pull request as ready for review April 22, 2024 18:08
@davsclaus
Copy link
Contributor

Okay we have merged some other PRs so this PR needs to be updated thanks

@davsclaus
Copy link
Contributor

Oh do you mind updating the upgrade guide doc about this change so users would be aware that some options are changed etc.

Add a section to
https://github.com/apache/camel/blob/main/docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_6.adoc

@github-actions github-actions bot added the docs label Apr 25, 2024
@davsclaus davsclaus merged commit ee9ad45 into apache:main Apr 25, 2024
4 checks passed
4nt01ne pushed a commit to 4nt01ne/camel that referenced this pull request May 14, 2024
* CAMEL-20266: Use high-level Azure Service Bus client

* Add default value to `maxConcurrentCalls` metadata

* Commit missing generated sources

* Rewrite integration test for ServiceBusConsumer

* Rewrite integration test for ServiceBusProducer

* Correct typos

* Refactor `ServiceBusSenderOperationsTest` and framework

* Remove redundant tests and framework

* Implement unit test for `ServiceBusConsumer`

* Fix formatting

* Tweak `ServiceBusConsumerTest` verifications

* Improve `ServiceBusConsumerTest` assertions

* Document configuration changes in migration guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants