Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonarfix for instanceof check and cast in CamelJavaParserHelper.java #13918

Closed
wants to merge 1 commit into from
Closed

Sonarfix for instanceof check and cast in CamelJavaParserHelper.java #13918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions ...amel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaParserHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,8 +338,8 @@ private static void extractEndpointUriFromArgument(
return;
}
}
if (fields && arg instanceof SimpleName) {
FieldSource<JavaClassSource> field = ParserCommon.getField(clazz, block, (SimpleName) arg);
if (fields && arg instanceof SimpleName simpleName) {
FieldSource<JavaClassSource> field = ParserCommon.getField(clazz, block, simpleName);
if (field != null) {
// find the endpoint uri from the annotation
AnnotationSource<JavaClassSource> annotation = field.getAnnotation("org.apache.camel.cdi.Uri");
Expand All @@ -350,20 +350,20 @@ private static void extractEndpointUriFromArgument(
Expression exp = extractExpression(annotation.getInternal());
String uri = CamelJavaParserHelper.getLiteralValue(clazz, block, exp);
if (!Strings.isNullOrEmpty(uri)) {
int position = ((SimpleName) arg).getStartPosition();
int len = ((SimpleName) arg).getLength();
int position = (simpleName).getStartPosition();
int len = (simpleName).getLength();
uris.add(new ParserResult(node, position, len, uri));
}
} else {
// the field may be initialized using variables, so we need to evaluate those expressions
Object fi = field.getInternal();
if (fi instanceof VariableDeclaration) {
Expression exp = ((VariableDeclaration) fi).getInitializer();
if (fi instanceof VariableDeclaration variableDeclaration) {
Expression exp = (variableDeclaration).getInitializer();
String uri = CamelJavaParserHelper.getLiteralValue(clazz, block, exp);
if (!Strings.isNullOrEmpty(uri)) {
// we want the position of the field, and not in the route
int position = ((VariableDeclaration) fi).getStartPosition();
int len = ((VariableDeclaration) fi).getLength();
int position = (variableDeclaration).getStartPosition();
int len = (variableDeclaration).getLength();
uris.add(new ParserResult(node, position, len, uri));
}
}
Expand Down Expand Up @@ -441,8 +441,8 @@ private static void doParseCamelLanguage(
if (list != null && list.size() == 1) {
ASTNode o = (ASTNode) list.get(0);
ASTNode p = o.getParent();
if (p instanceof MethodInvocation) {
String pName = ((MethodInvocation) p).getName().getIdentifier();
if (p instanceof MethodInvocation methodInvocation) {
String pName = (methodInvocation).getName().getIdentifier();
if (language.equals(pName)) {
// okay find the parent of the language which is the method that uses the language
parent = (Expression) p.getParent();
Expand Down Expand Up @@ -487,8 +487,8 @@ private static boolean isLanguagePredicate(String name) {

public static String getLiteralValue(JavaClassSource clazz, Block block, Expression expression) {
// unwrap parenthesis
if (expression instanceof ParenthesizedExpression) {
expression = ((ParenthesizedExpression) expression).getExpression();
if (expression instanceof ParenthesizedExpression parenthesizedExpression) {
expression = (parenthesizedExpression).getExpression();
}

if (expression instanceof StringLiteral stringLiteral) {
Expand All @@ -515,8 +515,8 @@ public static String getLiteralValue(JavaClassSource clazz, Block block, Express
return "{{" + name + "}}";
}

if (expression instanceof SimpleName) {
FieldSource<JavaClassSource> field = ParserCommon.getField(clazz, block, (SimpleName) expression);
if (expression instanceof SimpleName expSimpleName) {
FieldSource<JavaClassSource> field = ParserCommon.getField(clazz, block, expSimpleName);
if (field != null) {
// is the field annotated with a Camel endpoint
if (field.getAnnotations() != null) {
Expand All @@ -535,7 +535,7 @@ public static String getLiteralValue(JavaClassSource clazz, Block block, Express
return endpointTypeCheck(clazz, block, field);
} else {
// we could not find the field in this class/method, so its maybe from some other super class, so insert a dummy value
final String fieldName = ((SimpleName) expression).getIdentifier();
final String fieldName = (expSimpleName).getIdentifier();
return "{{" + fieldName + "}}";
}
} else if (expression instanceof InfixExpression ie) {
Expand Down
Loading