Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zipsplitter null body #15638

Merged
merged 3 commits into from
Sep 22, 2024
Merged

Conversation

thomas-gantenbein-tga
Copy link
Contributor

Description

See https://camel.zulipchat.com/#narrow/stream/257298-camel/topic/Idiomatic.20way.20to.20pollEnrich.20until.20there.20are.20no.20more.20items: In case one of the incoming bodies is null, this change should avoid failure of ZipAggregationStrategy.

I also addressed SonarQube warnings about cognitive complexity and removed deprecated annotations from test code while I was at it.

Viewing the three commits individually is probably best to see what changed in terms of functionality and what was just refactoring.

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@davsclaus davsclaus merged commit 469f422 into apache:main Sep 22, 2024
5 checks passed
@davsclaus
Copy link
Contributor

I wonder if you would check camel-tarfile if the agg strategy there has similar issue

@thomas-gantenbein-tga
Copy link
Contributor Author

You are right: It does have the same problem. Will address that in another PR.

davsclaus pushed a commit that referenced this pull request Oct 8, 2024
* Return oldExchange when incoming exchange body is null

* Remove deprecated `doPresetup` method

* Reduce cognitive complexity

---------

Co-authored-by: Thomas Gantenbein <[email protected]>
davsclaus pushed a commit that referenced this pull request Oct 8, 2024
* Return oldExchange when incoming exchange body is null

* Remove deprecated `doPresetup` method

* Reduce cognitive complexity

---------

Co-authored-by: Thomas Gantenbein <[email protected]>
Croway pushed a commit to Croway/camel that referenced this pull request Oct 14, 2024
* Return oldExchange when incoming exchange body is null

* Remove deprecated `doPresetup` method

* Reduce cognitive complexity

---------

Co-authored-by: Thomas Gantenbein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants