-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zipsplitter null body #15638
Zipsplitter null body #15638
Conversation
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
I wonder if you would check |
You are right: It does have the same problem. Will address that in another PR. |
* Return oldExchange when incoming exchange body is null * Remove deprecated `doPresetup` method * Reduce cognitive complexity --------- Co-authored-by: Thomas Gantenbein <[email protected]>
* Return oldExchange when incoming exchange body is null * Remove deprecated `doPresetup` method * Reduce cognitive complexity --------- Co-authored-by: Thomas Gantenbein <[email protected]>
* Return oldExchange when incoming exchange body is null * Remove deprecated `doPresetup` method * Reduce cognitive complexity --------- Co-authored-by: Thomas Gantenbein <[email protected]>
Description
See https://camel.zulipchat.com/#narrow/stream/257298-camel/topic/Idiomatic.20way.20to.20pollEnrich.20until.20there.20are.20no.20more.20items: In case one of the incoming bodies is null, this change should avoid failure of ZipAggregationStrategy.
I also addressed SonarQube warnings about cognitive complexity and removed deprecated annotations from test code while I was at it.
Viewing the three commits individually is probably best to see what changed in terms of functionality and what was just refactoring.