Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-21253 - Camel AWS Kinesis: KCL Consumers, make the ConfigsBuild… #15674

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Sep 24, 2024

…er for metrics of the Scheduler enable/disable

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

…er for metrics of the Scheduler enable/disable

Signed-off-by: Andrea Cosentino <[email protected]>
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@oscerd
Copy link
Contributor Author

oscerd commented Sep 24, 2024

/component-tests aws

Result ✅ The tests passed successfully

Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

@oscerd oscerd merged commit 6c7a0c9 into main Sep 24, 2024
5 checks passed
@oscerd
Copy link
Contributor Author

oscerd commented Sep 24, 2024

@davsclaus this could help user to avoid being billed for CloudWatch usage, so I would like to backport to 4.8.x, but it will introduce a new option, not invasive, but a new one.

@davsclaus
Copy link
Contributor

Yeah sure go ahead

oscerd added a commit that referenced this pull request Sep 26, 2024
…er for metrics of the Scheduler enable/disable (#15674)

Signed-off-by: Andrea Cosentino <[email protected]>
oscerd added a commit that referenced this pull request Sep 26, 2024
…er for metrics of the Scheduler enable/disable (#15674) (#15711)

Signed-off-by: Andrea Cosentino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants