Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dependency management #15745

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Cleanup dependency management #15745

merged 3 commits into from
Sep 30, 2024

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Sep 28, 2024

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@gnodet gnodet merged commit 19c0e60 into apache:main Sep 30, 2024
4 checks passed
@davsclaus
Copy link
Contributor

This may have caused camel-jbang-core to not compile

[ERROR] /Users/davsclaus/workspace/camel/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/RunHelper.java:[47,47] cannot access org.codehaus.plexus.util.xml.pull.XmlPullParserException
[ERROR] class file for org.codehaus.plexus.util.xml.pull.XmlPullParserException not found

@davsclaus
Copy link
Contributor

Okay seems like adding

        <!-- maven -->
        <dependency>
            <groupId>org.codehaus.plexus</groupId>
            <artifactId>plexus-xml</artifactId>
        </dependency>

to the pom.xml makes it compile

@davsclaus
Copy link
Contributor

okay it seems it causes more problems - we should consider reverting this.
tests in camel-jbang-core is failing, and the jbang is not working correctly.

I am trying again tomorrow to be sure, as I want to do a full rebuild with and without this commit

@gnodet
Copy link
Contributor Author

gnodet commented Sep 30, 2024

okay it seems it causes more problems - we should consider reverting this. tests in camel-jbang-core is failing, and the jbang is not working correctly.

I am trying again tomorrow to be sure, as I want to do a full rebuild with and without this commit

That could definitely be the cause. I did a full successful rebuild from a clean state, but without running tests...

@davsclaus
Copy link
Contributor

Okay I did 2 full rebuilds this morning

  • main (as is) = fails
  • reverted = ok

I am going to revert this, and @gnodet maybe you can find out the problem or maybe do less of a cleanup to narrow down where it starts to fail

davsclaus added a commit that referenced this pull request Oct 1, 2024
davsclaus pushed a commit that referenced this pull request Oct 1, 2024
davsclaus added a commit that referenced this pull request Oct 1, 2024
gnodet added a commit to gnodet/camel that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants