Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-21018: Create a Camel TorchServe component #15804

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

tadayosi
Copy link
Member

@tadayosi tadayosi commented Oct 2, 2024

Description

Initial implementation of a Camel TorchServe component. As the pull req is getting bigger, I split it into parts. Following the pull req, I'll submit more enhancements later:

  • Add IT tests
  • Support passing parameters as headers more comprehensively

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

https://issues.apache.org/jira/browse/CAMEL-21018

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@tadayosi
Copy link
Member Author

tadayosi commented Oct 3, 2024

I'm now rewriting my pull req with Spring RestTemplate instead of OkHttp according to Claus' suggestion. Once done, I'll let you know again.

-                <library>okhttp4-gson</library>
+                <library>resttemplate</library>

@davsclaus davsclaus marked this pull request as draft October 3, 2024 12:54
@github-actions github-actions bot added the dsl label Oct 4, 2024
@tadayosi tadayosi marked this pull request as ready for review October 4, 2024 05:46
@tadayosi
Copy link
Member Author

tadayosi commented Oct 4, 2024

Turned out resttemplate brings another problem to the generated openapi client, so I decided to rewrite it with openapi-generator & apache-httpclient. It now works fine.

-                                <library>okhttp4-gson</library>
+                                <library>apache-httpclient</library>

@davsclaus Please check it again.

@tadayosi tadayosi merged commit 4d6485e into apache:main Oct 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants