[CELEBORN-1799][CIP-14] Add celebornConf to cppClient #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FMX Could you kindly review this PR? Thanks a lot. Any suggestion is welcome. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3027 +/- ##
==========================================
- Coverage 32.99% 32.68% -0.30%
==========================================
Files 331 336 +5
Lines 19842 20032 +190
Branches 1787 1792 +5
==========================================
+ Hits 6545 6546 +1
- Misses 12933 13123 +190
+ Partials 364 363 -1 ☔ View full report in Codecov by Sentry. |
FMX
reviewed
Dec 25, 2024
| const std::unordered_map<std::string, folly::Optional<std::string>> | ||
| CelebornConf::kDefaultProperties = { | ||
| STR_PROP(kRpcLookupTimeout, "30s"), | ||
| STR_PROP(kClientRpcGetReducerFileGroupRpcAskTimeout, "240s"), |
There was a problem hiding this comment.
The default value of this config is 30s. We should align the default values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add CelebornConf to cppClient.
Why are the changes needed?
The CelebornConf will be used as configuration module in cppClient.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Compilation and UTs.