Expand logging information when genericEvent is waiting #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the genericEventTimeout
pnoltes
requested changes
Jan 7, 2025
Add CELIX_ALLOWED_PROCESSING_TIME_FOR_GENERIC_EVENT_IN_SECONDS to documentation and C++ header. Set genericEventTimeout in start of framework modified: documents/framework.md modified: libs/framework/gtest/src/CelixFrameworkTestSuite.cc modified: libs/framework/include/celix/Constants.h modified: libs/framework/src/framework.c modified: libs/framework/src/framework_private.h
pnoltes
reviewed
Jan 8, 2025
pnoltes
approved these changes
Jan 8, 2025
PengZheng
reviewed
Jan 11, 2025
| fw_log(fw->logger, CELIX_LOG_LEVEL_WARNING, "Generic event with id %li not finished.", eventId); | ||
| logAbsTime = celixThreadCondition_getDelayedTime(5); | ||
| } | ||
| fw_log(fw->logger, |
There was a problem hiding this comment.
Potential use-after-free. dispatcher.mutex is release when waiting for dispatcher.cond, and thus event could be removed. The intention is good but we can not really do this.
PengZheng
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time commit here,
When making use of celix, situations can occur that a fired genericEvent is not yet finished, resulting in multiple warning messages being printed in the logging. These messages contain very limited information on which event from which bundle is waiting.
Hence this pull request to update the warning message with more information, containing eventName, eventId, bundleName and bundleId. This should help in deducing which generic Events from which bundles are waiting a long time.
Also added an environment variable to support setting of the timeout of generic events, similar as to how scheduled events have the variable for setting the timeout in seconds.