Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded SELinux relabel for Celix repo root volume mount #786

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

rlenferink
Copy link
Member

@rlenferink rlenferink commented Jan 12, 2025

The relabel is not needed since the --security-opt label=disable option is already passed when starting the container

The relabel is not needed since the '--security-opt label=disable' option is already passed when starting the container
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.39%. Comparing base (4da5eee) to head (c787df8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
+ Coverage   91.34%   91.39%   +0.04%     
==========================================
  Files         234      234              
  Lines       29052    29052              
==========================================
+ Hits        26537    26551      +14     
+ Misses       2515     2501      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pnoltes pnoltes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, I Ithought relabeling was needed to ensure proper write permissions, but I'm glad to see this correction.

@PengZheng PengZheng merged commit 22effe4 into master Jan 13, 2025
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants