Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to sizeclasses.com #1342

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

igorsantos07
Copy link
Contributor

Platforms affected

iOS

Motivation and Context

That website is now parked, probably got abandoned.

Description

Just removed a line referring to the defunct website.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@igorsantos07
Copy link
Contributor Author

BTW, that checklist seems generic, since this docs repository obviously has no tests haha

@dpogue
Copy link
Member

dpogue commented Jan 5, 2024

Thanks for finding and fixing this! 🙇🏼

I see you've updated it for the current version of the docs (12.x), could you also remove it from the dev version of the docs? That way it won't re-appear when we publish a v13. The dev version file should be https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/core/features/splashscreen/index.md

…docs

That website is now parked, probably got abandoned.
@igorsantos07
Copy link
Contributor Author

Whoops! Didn't realize that. Done!

@NiklasMerz NiklasMerz merged commit c46bcd4 into apache:master Jan 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants