Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Windows occurrences from site "Create a Plugin" #1354

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

GitToTheHub
Copy link
Contributor

The windows platform is not supported anymore

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@GitToTheHub GitToTheHub changed the title Remove Windows Plugins Link from Remove Windows occurrences from site "Create a Plugin" Jul 13, 2024
@GitToTheHub GitToTheHub marked this pull request as ready for review July 13, 2024 15:11
@breautek
Copy link
Contributor

I think these improvements are good, especially since that windows link is actually a 404 as well.

The only thing is, the changes are made to dev which means they will apply on our next version snapshot, which is good but I think these changes also warrants being updated on our 12.x version of the docs as well. This can be done by mirroring the changeset on https://github.com/apache/cordova-docs/blob/master/www/docs/en/12.x/guide/hybrid/plugins/index.md file. This way when the PR is merged the change will be live on the current docs as well.

Would you like to do this?

@GitToTheHub
Copy link
Contributor Author

No problem, I can do that 🙂

The windows platform is not supported anymore
- The windows platform is not supported anymore.
- The "Windows Plugins"-Link was directing to a 404 page
@GitToTheHub
Copy link
Contributor Author

@breautek I reflected the changes to the 12.x docs and squashed the changes on the dev-docs to one commit

@breautek
Copy link
Contributor

Awesome thanks!

@breautek breautek merged commit 947517b into apache:master Jul 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants