Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(android): fix incorrect GradlePlugin* preferences #1365

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

erisu
Copy link
Member

@erisu erisu commented Oct 22, 2024

Motivation and Context

Fix incorrect Android GradlePlugin(*) preferences.

Fixes #1362

Description

  • One of the preferences GradlePluginGoogleServicesEnabled is listed twice when it should be GradlePluginGoogleServicesVersion (Fixed all the way back to 10.x docs.)
  • Removed invalid preference AndroidGradlePluginGoogleServicesVersion. (12.x & dev docs.)
  • Removed invalid preference AndroidGradlePluginGoogleServicesEnabled. (12.x & dev docs.)
  • Removed duplicated preference GradlePluginKotlinEnabled from dev docs.

Testing

Built docs.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu merged commit d94123d into apache:master Oct 23, 2024
1 check passed
@erisu erisu deleted the doc/fix-incorrect-android-preferences branch October 23, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GradlePluginGoogleServicesEnabled duplicated
3 participants