Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment with W3C Battery API #24

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Alignment with W3C Battery API #24

wants to merge 9 commits into from

Conversation

pContat
Copy link

@pContat pContat commented Jun 24, 2015

Addition of the methode navigator.getBattery which return a BatteryManager object using promises to align with the W3C API

Here is the associate Jira issue.

Some notes on the proposed changes:

  • The previous navigator.battery and the new navigator.getBattery can't run together on android ( only one callbackContext allowed with the current version)
  • chargingtime and dischargingtime value aren't available for now (since that data is not provided by default at least on Android and FirefoxOS)

Also, I was not clear whether there is a coding guideline (formatting, etc) ? I tried to keep it close to the original

@pContat
CB-6065 Initialisation
a020f8f 
- CB-7583 : readonly property called charging
- CB-7589 : readonly property called level
- CB-7585 : readonly property called chargingTime
- CB-7587 : readonly property called dischargingTime
- CB-7581 : The W3C battery status specification uses promises.
@pContat
CB-7581 and CB-7584 : eventHandler and access to batteryManager
2980399 
- CB-7581 : Battery information should be accessible from navigator.getBattery()
- CB-7584 : event handler: onchargingchange
@pContat
CB-7586 chargingTimeChange event
70b086f
@pContat
CB-7588 and CB-7590 : dischargingTimeChange, levelchange event
71675c6
@pContat
BatteryManager implement EventTarget using cordova chanels
4df4114
@pContat
Add test for new implementation
2354a7e
@pContat
CB-7589 : level between 0 and 1.0 and add manual test
3cc6bb3
@pContat
Add Promise polyfill plugin and browser detection
4074bc7
@pContat
Fix getOriginalSymbol param with navigator.getBattery
82d9b2b
@sarangan12
Copy link

Let there be tests

@cordova-qa
Copy link

Cordova CI Build has one or more failures.

Commit - Link
Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 8.1 Store Link Link Link
Windows 10 Store Link Link Link
Windows 8.1 Phone Link Link Link
iOS Link Link Link
Android Mac Link Link Link

@halindrome
Copy link

Is there some way we can rejuvenate this PR? I think this is critical functionality - in particular since the existing implementation does not seem to work on Android 7 as far as I can tell.

@achs0
Copy link

achs0 commented Mar 7, 2018

I'm a little confused. It seems, that this is implemented in phonegap (the "mirror" of cordova):
https://github.com/phonegap/phonegap-plugin-battery-status

@janpio
Copy link
Member

janpio commented Mar 7, 2018 •
edited
Loading

That is a fork of this plugin:

This branch is 15 commits ahead, 33 commits behind apache:master.

So while someone did 15 commits on the fork, it also didn't get 33 commits that happened here.

@macdonst
Copy link
Member

macdonst commented Mar 7, 2018

@achs0 @janpio yeah, we forked the plugin so we could update the API as part of our rejuvenation campaign of plugin api's. The plan was to send a PR to the cordova battery status plugin once we had android, ios and windows done. We have a partial windows implementation but it's not ready yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pContat @sarangan12 @cordova-qa @halindrome @achs0 @janpio @macdonst