-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dev Dockerfile for nouveau #275
base: main
Are you sure you want to change the base?
Conversation
Looking good! I can build the image, run it in docker and make a test.build.webm |
Ok! got a working test.compose.webm |
Hey @mrjones-plip, first, thank you for your contribution to CouchDB. Why do you need a separate "Nouveau-only" Image for development instead of a All-In-One (CouchDB + Nouveau) Docker dev image? |
Hi @big-r81! Thanks for the question - great to get extra eyes on this. We'd wanted to test an upgrade scenario for Nouveau, so in order to do this we needed to start on 3.4.2 and then upgrade to something newer. The all in one you mentioned is pinned to 3.4.2 via an The solution in this PR removes the This PR also brings parity to the |
What about to update the Dockerfile in the dev directory to build CouchDB and Nouveau from main - I would guess it was created for that reason? (never used it personally) So we would need to add
The you would have a Docker image from main with all inside. |
Thanks for the feedback @big-r81 ! I'd interpreted the
I admit using a lemme know! |
Overview
While some work was done in #257 to get a development build of
main
in Docker, there's still no easy way to get a development image of Nouveau with latest passing build. This PR aims to use the latest passing build artifacts (seelastSuccessfulBuild
in CI) for Nouveau into a docker image.The approach will be to take the
Dockerfile
found in 3.4.2 for Nouveau and instead of using the released package from theapt
repo, instead download the.deb
from CI and install this. As such, theDockerfile
will skip all the effort to add the GPG key and adding the CouchDB Apt repo. It will also not installtini
(which looks to be unused anyway)Changes
Dockerfile-nouveau
in thedev
directorycompose.yml
indev
for easydocker compose up
of dev containers.ini
and.yaml
files for running dev compose per above.gitignore
for those JetBrains IDE users like me ;)Testing recommendations
Docker
cd dev
docker build -t couchdb-nouveau:dev -f Dockerfile-nouveau .
docker run -p 5988:5988 couchdb-nouveau:dev
curl 172.17.0.2:5988/openapi.yaml
Docker compose
cd dev
docker compose up
All images should build (might take a good loooooong while for couchdb!) and then start up.
GitHub issue number
NA
Related Pull Requests
This IS a pull request ;)
Checklist