chore: Remove redundant processing from exprToProtoInternal

[andygrove]

Which issue does this PR close?

N/A

Rationale for this change

We have two very similar methods, exprToProto and exprToProtoInternal.

exprToProto performs a transformation on the expression tree to handle decimal promotion and then calls into the recursive method exprToProtoInternal to perform the translation to protobuf.

Within exprToProtoInternal we should only recurse into exprToProtoInternal but in some cases we were calling exprToProto instead,. This was not harmful but is performing redundant work.

What changes are included in this PR?

• Improve documentation
• Replace calls to exprToProto with exprToProtoInternal within exprToProtoInternal

How are these changes tested?

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.16%. Comparing base (f09f8af) to head (532fdbc).
Report is 17 commits behind head on main.

Additional details and impacted files

@@              Coverage Diff              @@
##               main    #1351       +/-   ##
=============================================
- Coverage     56.12%   39.16%   -16.96%     
- Complexity      976     2065     +1089     
=============================================
  Files           119      262      +143     
  Lines         11743    60323    +48580     
  Branches       2251    12836    +10585     
=============================================
+ Hits           6591    23627    +17036     
- Misses         4012    32223    +28211     
- Partials       1140     4473     +3333     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[parthchandra]

lgtm

[comphead]

lgtm thanks @andygrove