feat: Upgrade to DataFusion 45 #1364
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1364 +/- ##
=============================================
- Coverage 56.12% 39.17% -16.96%
- Complexity 976 2067 +1091
=============================================
Files 119 262 +143
Lines 11743 60323 +48580
Branches 2251 12836 +10585
=============================================
+ Hits 6591 23631 +17040
- Misses 4012 32219 +28207
- Partials 1140 4473 +3333 ☔ View full report in Codecov by Sentry. |
parthchandra
reviewed
Feb 1, 2025
native/Cargo.toml
Outdated
| datafusion-execution = { git = "https://github.com/apache/datafusion", rev = "5592834", default-features = false } | ||
| datafusion-physical-plan = { git = "https://github.com/apache/datafusion", rev = "5592834", default-features = false } | ||
| datafusion-physical-expr = { git = "https://github.com/apache/datafusion", rev = "5592834", default-features = false } | ||
| datafusion = { git = "https://github.com/apache/datafusion", rev = "8d006a2", default-features = false, features = ["unicode_expressions", "crypto_expressions"] } |
There was a problem hiding this comment.
For my edification, is there a reason why we have to use a git revision. Is this not published to a public repository?
There was a problem hiding this comment.
DF 45 is not released yet, but will be in the next week or so. The goal of this and the previous PR is to incrementally update so that we are ready once the release is published.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1304
Follows on from partial upgrade in #1332
Rationale for this change
I plan on bumping the DF rev in this PR until DF 45 is released.
What changes are included in this PR?
How are these changes tested?