Add foreign table providers #921
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsaucer
force-pushed
the
feature/ffi
branch
from
fcf9475
to
f5f983c
Compare
ion-elgreco
reviewed
Nov 4, 2024
| pub fn register_table_provider( | ||
| &mut self, | ||
| name: &str, | ||
| provider: Bound<'_, PyAny>, |
There was a problem hiding this comment.
Just to understand, taking delta-rs as an example.
The provider would be an instance of a deltatable object?
There was a problem hiding this comment.
Here is what you would need to implement in delta-rs as a python method on RawDeltaTable
fn __datafusion_table_provider__<'py>(&self, py: Python<'py>) -> PyResult<Bound<'py, PyCapsule>> {
let name = CString::new("datafusion_table_provider").unwrap();
let provider = FFI_TableProvider::new(Arc::new(self._table.clone()));
PyCapsule::new_bound(py, provider, Some(name.clone()))
}
Does that answer the question?
| provider: Bound<'_, PyAny>, | ||
| py: Python, | ||
| ) -> PyResult<()> { | ||
| if provider.hasattr("__datafusion_table_provider__")? { |
There was a problem hiding this comment.
Should we raise when it doesn't have this attribute, it might give the wrong impression for users that they registered it but nothing happened
There was a problem hiding this comment.
Good point! Added.
This was referenced Nov 6, 2024
timsaucer
force-pushed
the
feature/ffi
branch
from
f5f983c
to
7240d44
Compare
timsaucer
force-pushed
the
feature/ffi
branch
from
7240d44
to
01a15f1
Compare
|
Now that 43.0.0 has merged into main, I've rebased and I'll work next on adding example and unit tests. |
…un during the first pass of pytest when the module hasn't been built
ion-elgreco
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #823
Closes #941
Rationale for this change
This feature enables DataFusion python to interoperate with foreign table providers that implement TableProvider and expose it via PyCapsule
What changes are included in this PR?
Adds a feature to register a table provider in the session context.
Are there any user-facing changes?
Addition only, no existing APIs modified.