Move JoinSelection into datafusion-physical-optimizer crate (#14073) #14085
+448
−403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got Min Supported Rust Version error during checks. Tried to fix it by using suggestions:
|
alamb
approved these changes
Jan 12, 2025
There was a problem hiding this comment.
Thank you @cj-zhukov -- this looks great. I looked into the msrv failure and pushed a fix
I noticed one thing that could be improved / simplified, but otherwise this PR looks great 👌 . I also think we can merge this PR as is and do the changes as a follow on if desired.
MSRV Failrue
andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion2/datafusion-cli$ cargo msrv verify
[Meta] cargo-msrv 0.17.1
Compatibility Check #1: Rust 1.80.1
[FAIL] Is incompatible
╭────────────────────────────────────────────────────────────────────────╮
│ error: rustc 1.80.1 is not supported by the following packages: │
│ [email protected] requires rustc 1.81.0 │
│ [email protected] requires rustc 1.81.0 │
│ [email protected] requires rustc 1.81.0 │
│ Either upgrade rustc or select compatible dependency versions with │
│ `cargo update <name>@<current-ver> --precise <compatible-ver>` │
│ where `<compatible-ver>` is the latest version supporting rustc 1.80.1 │
│ │
│ │
╰────────────────────────────────────────────────────────────────────────╯
Crate source was found to be incompatible with Rust version '1.80.1' specified as MSRV in the Cargo manifest located at '/Users/andrewlamb/Software/datafusion2/datafusion-cli/Cargo.toml'This basically means that some of the aws sdk crates broke the MSRV. I pushed a fix in b9fdb38 that should fix it.
| @@ -903,7 +900,7 @@ mod tests_statistical { | |||
| let original_schema = join.schema(); | |||
|
|
|||
| let optimized_join = JoinSelection::new() | |||
| .optimize(join.clone(), &ConfigOptions::new()) | |||
| .optimize(Arc::<HashJoinExec>::clone(&join), &ConfigOptions::new()) | |||
There was a problem hiding this comment.
I think this can be simplified to the following (no need to explicitly spell out the type):
Suggested change
| .optimize(Arc::<HashJoinExec>::clone(&join), &ConfigOptions::new()) | |
| .optimize(Arc::clone(&join), &ConfigOptions::new()) |
Similarly for the other changes in this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #14073.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?