Remove use of deprecated dict_id in datafusion-proto (#14173) #14227
Conversation
github-actions
bot
added
physical-expr
…n-datafusion-proto
There was a problem hiding this comment.
It seems that datafusion/core/src/physical_optimizer/enforce_sorting.rs somehow is added to this PR accidentally (it was moved on main recently, so perhaps this happened during a merge accidentally?)
Thanks for working on this @cj-zhukov
Andrew, I'm afraid it was done accidentally |
| @@ -108,8 +108,7 @@ message Field { | |||
| // for complex data types like structs, unions | |||
| repeated Field children = 4; | |||
| map<string, string> metadata = 5; | |||
| int64 dict_id = 6; | |||
| bool dict_ordered = 7; | |||
| bool dict_ordered = 6; | |||
There was a problem hiding this comment.
is dict_ordered still used anywhere?
There was a problem hiding this comment.
I'm not sure, but we can open PR and handle it. I'm ready to work on it.
There was a problem hiding this comment.
Awesome -- thanks. Let's get this PR ready to go and then we can work on remvoing that as a follow on
There was a problem hiding this comment.
Thank you @cj-zhukov -- this is looking close
I also took the liberty of merging up from main and removing the accidentally added file
github-actions
bot
added
documentation
cj-zhukov
force-pushed
the
cj-zhukov/Remove-use-of-deprecated-dict_id-in-datafusion-proto
branch
from
14c1e4d to
07157a7
Compare
github-actions
bot
removed
documentation
There was a problem hiding this comment.
Thank you @cj-zhukov
@andygrove are we happy that dict_id is no longer needed in DataFusion?
cc @thinkharderdev and @avantgardnerio who I think may have contributed the code for field_id originally
Which issue does this PR close?
Closes #14173.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?