-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Update to arrow-rs / parquet 54.1.0
#14328
base: main
Are you sure you want to change the base?
Conversation
@@ -369,8 +370,8 @@ fn try_cast_numeric_literal( | |||
// Different precision for decimal128 can store different range of value. | |||
// For example, the precision is 3, the max of value is `999` and the min | |||
// value is `-999` | |||
MIN_DECIMAL_FOR_EACH_PRECISION[*precision as usize - 1], | |||
MAX_DECIMAL_FOR_EACH_PRECISION[*precision as usize - 1], | |||
MIN_DECIMAL128_FOR_EACH_PRECISION[*precision as usize], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -311,7 +311,7 @@ impl FileOpener for ArrowOpener { | |||
{ | |||
decoder.read_dictionary( | |||
dict_block, | |||
&Buffer::from_bytes(dict_result.into()), | |||
&Buffer::from(dict_result), |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dict_block, | ||
&Buffer::from_bytes(dict_result.into()), | ||
)?; | ||
decoder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/apache/datafusion/actions/runs/12996259121/job/36244947022?pr=14328 appears to be a real difference
I am |
According to
You can verify this by applying a diff such as this locally: diff --git a/Cargo.toml b/Cargo.toml
index 1c8f9f0a1..8025d32b8 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -190,15 +190,15 @@ unexpected_cfgs = { level = "warn", check-cfg = ["cfg(tarpaulin)"] }
unused_qualifications = "deny"
[patch.crates-io]
-arrow = { git = "https://github.com/apache/arrow-rs.git", rev = "6aaff7e38a573f797b31f89f869c3706cbe26e37" }
-arrow-array = { git = "https://github.com/apache/arrow-rs.git", rev = "6aaff7e38a573f797b31f89f869c3706cbe26e37" }
-arrow-buffer = { git = "https://github.com/apache/arrow-rs.git", rev = "6aaff7e38a573f797b31f89f869c3706cbe26e37" }
-arrow-cast = { git = "https://github.com/apache/arrow-rs.git", rev = "6aaff7e38a573f797b31f89f869c3706cbe26e37" }
-arrow-data = { git = "https://github.com/apache/arrow-rs.git", rev = "6aaff7e38a573f797b31f89f869c3706cbe26e37" }
-arrow-ipc = { git = "https://github.com/apache/arrow-rs.git", rev = "6aaff7e38a573f797b31f89f869c3706cbe26e37" }
-arrow-schema = { git = "https://github.com/apache/arrow-rs.git", rev = "6aaff7e38a573f797b31f89f869c3706cbe26e37" }
-arrow-select = { git = "https://github.com/apache/arrow-rs.git", rev = "6aaff7e38a573f797b31f89f869c3706cbe26e37" }
-arrow-string = { git = "https://github.com/apache/arrow-rs.git", rev = "6aaff7e38a573f797b31f89f869c3706cbe26e37" }
-arrow-ord = { git = "https://github.com/apache/arrow-rs.git", rev = "6aaff7e38a573f797b31f89f869c3706cbe26e37" }
-arrow-flight = { git = "https://github.com/apache/arrow-rs.git", rev = "6aaff7e38a573f797b31f89f869c3706cbe26e37" }
-parquet = { git = "https://github.com/apache/arrow-rs.git", rev = "6aaff7e38a573f797b31f89f869c3706cbe26e37" }
+arrow = { path="/Users/andrewlamb/Software/arrow-rs/arrow" }
+arrow-array = { path="/Users/andrewlamb/Software/arrow-rs/arrow-array" }
+arrow-buffer = { path="/Users/andrewlamb/Software/arrow-rs/arrow-buffer" }
+arrow-cast = { path="/Users/andrewlamb/Software/arrow-rs/arrow-cast" }
+arrow-data = { path="/Users/andrewlamb/Software/arrow-rs/arrow-data" }
+arrow-ipc = { path="/Users/andrewlamb/Software/arrow-rs/arrow-ipc" }
+arrow-schema = { path="/Users/andrewlamb/Software/arrow-rs/arrow-schema" }
+arrow-select = { path="/Users/andrewlamb/Software/arrow-rs/arrow-select" }
+arrow-string = { path="/Users/andrewlamb/Software/arrow-rs/arrow-string" }
+arrow-ord = { path="/Users/andrewlamb/Software/arrow-rs/arrow-ord" }
+arrow-flight = { path="/Users/andrewlamb/Software/arrow-rs/arrow-flight" }
+parquet = { path="/Users/andrewlamb/Software/arrow-rs/parquet" } And then running $ cargo test --test sqllogictests -- window From the list of commits on https://github.com/apache/arrow-rs/commits/main/?after=6aaff7e38a573f797b31f89f869c3706cbe26e37+34 you can see:
|
6ce98ad
to
a0097a2
Compare
a0097a2
to
7758936
Compare
Which issue does this PR close?
Rationale for this change
Keep up with dependencies
What changes are included in this PR?
Are these changes tested?
By existing CI
Are there any user-facing changes?