Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase MSRV to 1.81.0 #14330

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Increase MSRV to 1.81.0 #14330

merged 2 commits into from
Jan 28, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 27, 2025

Which issue does this PR close?

Rationale for this change

Per the policy: https://github.com/apache/datafusion?tab=readme-ov-file#rust-version-compatibility-policy

DataFusion's supports the last 4 stable Rust minor versions released and any such versions released within the last 4 months.

The most recent versions are 1.81, 1.82, 1.83, 1.84
https://github.com/rust-lang/rust/blob/master/RELEASES.md

Several of our dependencies now have a MSRV of 1.81

What changes are included in this PR?

Update MSRV to 1.81

Are these changes tested?

Are there any user-facing changes?

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb
we also need to change it in

datafusion-cli/Dockerfile

And here .devcontainer/Dockerfile looks like the version is missing which doesn't seem to be correct imho as it takes latest rustc

@alamb
Copy link
Contributor Author

alamb commented Jan 28, 2025

Thanks everyone; I want to merge this in to unblock a bunch of the other dependency upgrades. I will make a follow on PR to change this one:

Thanks @alamb
we also need to change it in

datafusion-cli/Dockerfile

@alamb alamb merged commit a4917d4 into apache:main Jan 28, 2025
27 checks passed
@alamb alamb deleted the alamb/bump_msrv branch January 28, 2025 20:33
@alamb
Copy link
Contributor Author

alamb commented Jan 28, 2025

And here .devcontainer/Dockerfile looks like the version is missing which doesn't seem to be correct imho as it takes latest rustc

BTW @comphead I think using the latest Rust in the dev container makes sense -- there is no reason why it needs to use the oldest rust supported by DataFusion (the MSRV)

Perhaps we should actually change the DataFusion CLI dockerfile the same way 🤔

@alamb alamb added the api change Changes the API exposed to users of the crate label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change Changes the API exposed to users of the crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants