-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore ability to run single SLT file #14355
Restore ability to run single SLT file #14355
Conversation
Make it possible again to run single SLT file, even if it's name is a substring of other file(s). For example, after the change, this command: cargo test --test sqllogictests -- test_files/union.slt runs `union.slt` file, but does not run `pg_compat_union.slt`.
a13c085
to
b0acc30
Compare
I made a small PR to your branch to show the # of files tested, verifying that
runs 2 files whereas
runs 1 file. I also verified that the sqlite tests ran without issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @findepi ! I verified this PR using #14359
Before this PR
andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$ cargo test --test sqllogictests -- test_files/union.slt
Compiling datafusion-sqllogictest v44.0.0 (/Users/andrewlamb/Software/datafusion/datafusion/sqllogictest)
Finished `test` profile [unoptimized + debuginfo] target(s) in 1.14s
Running bin/sqllogictests.rs (target/debug/deps/sqllogictests-3d953efd822e1e41)
Completed 0 tests in 0 seconds
After this PR it does
andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$ cargo test --test sqllogictests -- test_files/union.slt
Compiling datafusion-sqllogictest v44.0.0 (/Users/andrewlamb/Software/datafusion/datafusion/sqllogictest)
Finished `test` profile [unoptimized + debuginfo] target(s) in 1.53s
Running bin/sqllogictests.rs (target/debug/deps/sqllogictests-3d953efd822e1e41)
Completed 1 tests in 0 seconds
BTW I think it is currently possible to run a single file. For example this will run both cargo test --test sqllogictests -- union.slt However, it only matches on the file name (not the entire path) so using
LOL we did the same thing @Omega359 |
Thanks again @findepi |
Make it possible again to run single SLT file, even if it's name is a substring of other file(s).
For example, after the change, this command:
cargo test --test sqllogictests -- test_files/union.slt
runs
union.slt
file, but does not runpg_compat_union.slt
.The functionality was probably accidentally lost probably in #13936
cc @Omega359