-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable coercison for unmatched struct type #14409
base: main
Are you sure you want to change the base?
Conversation
3d0788e
to
e94ce44
Compare
Thank you @Lordworms -- I hope to review this tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Lordworms -- thank you very much for this PR and for working on the issue
While reviewing this PR I noticed a few other tests that I think we should add (are you willing to do so?)
- Adding a test for
coalesece(column1, column2)
and `coalesce(column2, column3) which is similar to union and case - Adding a test for comparison
column1 = column
andcolumn2 = column3
which is also similar
Then in terms of code, As this PR demonstrates, there are at least three places that do versions of this struct comparision that need to be changed as they have different versions of code that does about the same thing by coercing structs.
I think @jayzhan211's suggestion on https://github.com/apache/datafusion/pull/14384/files#r1937492704
Yes, I think type union resolution is the correct on for CASE
Means that we should be aiming towards consolidating / using the same rules.
Maybe you could move the checks into struct_coercion
and then update any other coercion that needed to coerce structs to use that one?
Sure, I can do that
Ok, I'll add that |
e94ce44
to
47c2460
Compare
1881347
to
3a2c298
Compare
3a2c298
to
7ff3769
Compare
Which issue does this PR close?
struct
field coercion #14396Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?