Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Support uncorrelated EXISTS #14474

Merged
merged 7 commits into from
Feb 5, 2025
Merged

core: Support uncorrelated EXISTS #14474

merged 7 commits into from
Feb 5, 2025
+181 −75

Conversation

findepi
Copy link
Member

@findepi findepi commented Feb 4, 2025 •
edited by alamb
Loading

@findepi
Accept any uncorrelated plan when checking subquery correlation
7a685d2 
For the purpose of decorrelation, an uncorrelated plan is a unit. No
verification needs to be performed on it.
@findepi
Extract variable
b21f89a 
Extract variable from a long if condition involving a match. Improves
readability.
@findepi
Simplify control flow
ea21df4 
Handle the unhandled case returning immediately. This adds additional
return point to the function, but removes subsequent if. At the point of
this additional return we know why we bail out (some unhandled
situation), later the None filter could be construed as a true
condition.
@findepi
Add more EXISTS SLT tests
9e28a08
@findepi
Support uncorrelated EXISTS
98a3dbf
@github-actions github-actions bot added logical-expr Logical plan and expressions optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt) labels Feb 4, 2025
alamb
alamb approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @findepi -- this looks like a nice improvement to me

datafusion/sqllogictest/test_files/subquery.slt Show resolved Hide resolved
datafusion/optimizer/src/decorrelate_predicate_subquery.rs Outdated Show resolved Hide resolved
datafusion/expr/src/logical_plan/invariants.rs Show resolved Hide resolved
@alamb alamb mentioned this pull request Feb 5, 2025
Closed
goldmedal
goldmedal approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @findepi. This way makes sense to me. 👍
I just noticed some comments may be out of date.

datafusion/sqllogictest/test_files/subquery.slt Outdated Show resolved Hide resolved
datafusion/optimizer/src/decorrelate_predicate_subquery.rs Outdated Show resolved Hide resolved
@findepi findepi changed the title Support uncorrelated EXISTS core: Support uncorrelated EXISTS Feb 5, 2025
@findepi findepi merged commit 61ab9d0 into apache:main Feb 5, 2025
26 checks passed
@findepi findepi deleted the findepi/support-uncorrelated-exists-d3ccb0 branch February 5, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldmedal goldmedal goldmedal approved these changes

@alamb alamb alamb approved these changes

@jonahgao jonahgao Awaiting requested review from jonahgao

Assignees
No one assigned
Labels
logical-expr Logical plan and expressions optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check_correlations_in_subquery should not check uncorrelated plan nodes
3 participants
@findepi @alamb @goldmedal